Correctly transform uint8array to string #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fstasi
force-pushed
the
sketch-sync-push
branch
from
f540e02 to
3813df0
Compare
|
fixes #634 |
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
IDE2 currently converts larger files to uint8arrays. When a file is then pushed to the cloud it needs to be conferted back to a string.
This process fails miserably, as we are trying to use
new TextDecoder().decode(content)which is broken in the electron version used by theia (electron/electron#18733)How
Replace
new TextDecoder().decode(content)withnew util.TextDecoder().decode(content)